This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: genmatch indent generated code


On Thu, Jul 9, 2015 at 5:23 PM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Thu, 9 Jul 2015, Jakub Jelinek wrote:
>
>> That violates the coding style by not using tabs ;)
>
> I knew it!  Somebody would notice, pffft.  Fixed in the committed version.

I also noticed it but didn't care ;)  But now I notice

  switch (TREE_CODE (t))
    {
      case SSA_NAME:

cases are indented too much, it should be

  switch (TREE_CODE (t))
    {
    case SSA_NAME:

Richard.

>
> Ciao,
> Michael.
> PS: this still isn't fully correct, as sometimes I start the strings with
> spaces which don't count towards the indent parameter, I don't align code
> coming from (with ...) and long lines aren't broken up.  Left as an
> excercise for the reader ;)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]