This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.


On 07/09/2015 08:13 AM, Jakub Jelinek wrote:
On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote:
---
  gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +-
  gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +-
  gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

I'd actually think it would be better to give up on the
UBSAN_* internal calls in tail merging.  Those internal pass
arguments based on their gimple_location, so tail merging breaks
them.
So I think the larger question here is should differences in gimple locations prevent tail merging? I'd tend to think not, which then begs the question, are the UBSAN calls special enough to warrant an exception?

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]