This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics



On 07/07/15 14:09, Kyrill Tkachov wrote:
Hi Alan,

On 07/07/15 13:34, Alan Lawrence wrote:
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html
For some context, the reference for these is at:
http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref.pdf

This patch is ok once you and Charles decide on how to proceed with the two prerequisites.

On second thought, the ACLE document at http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf

says in 12.2.1:
"float16 types are only available when the __fp16 type is defined, i.e. when supported by the hardware"

This indicates that float16 type and intrinsic availability should be gated on the availability of fp16
in the specified -mfpu. Look at some existing intrinsics like vcvt_f16_f32 for a way to gate these.

I notice that the float32x4_t is unconditionally defined in our arm_neon.h, however.
I think this is a bug and its definition should be #ifdef'd properly as well.

Thanks,

Kyrill


Thanks,
Kyrill



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]