This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C PATCH to use VAR_P

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: Joseph Myers <joseph at codesourcery dot com>
Date: Wed, 24 Jun 2015 10:55:32 -0600
Subject: Re: C PATCH to use VAR_P
Authentication-results: sourceware.org; auth=none
References: <20150624122507 dot GW10139 at redhat dot com>

On 06/24/2015 06:25 AM, Marek Polacek wrote:

Similarly to what Gaby did in 2013 for C++
(<https://gcc.gnu.org/ml/gcc-patches/2013-03/msg01271.html>), this patch
makes the c/ and c-family/ code use VAR_P rather than

   TREE_CODE (t) == VAR_DECL

(This is on top of the previous patch with is_global_var.)

Bootstrapped/regtested on x86_64-linux, ok for trunk?

2015-06-24  Marek Polacek  <polacek@redhat.com>

	* array-notation-common.c: Use VAR_P throughout.
	* c-ada-spec.c: Likewise.
	* c-common.c: Likewise.
	* c-format.c: Likewise.
	* c-gimplify.c: Likewise.
	* c-omp.c: Likewise.
	* c-pragma.c: Likewise.
	* c-pretty-print.c: Likewise.
	* cilk.c: Likewise.

	* c-array-notation.c: Use VAR_P throughout.
	* c-decl.c: Likewise.
	* c-objc-common.c: Likewise.
	* c-parser.c: Likewise.
	* c-typeck.c: Likewise.

I spot checked mostly for VAR_P vs !VAR_P correctness and everythinglooked correct. OK for the trunk. Consider any follow-ups to use VAR_Pin a similar way pre-approved.


jeff

References:
- C PATCH to use VAR_P
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]