This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[AArch64 Testsuite obvious] Reinstate torture-init and torture-finalize in advsimd-intrinsics.exp
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: marcus dot shawcroft at arm dot com, alalaw01 at arm dot com, christophe dot lyon at linaro dot org
- Date: Tue, 16 Jun 2015 10:24:06 +0100
- Subject: [AArch64 Testsuite obvious] Reinstate torture-init and torture-finalize in advsimd-intrinsics.exp
- Authentication-results: sourceware.org; auth=none
Hi,
advsimd-intrinsics.exp is polluting set-torture-options without
cleaning up after itself. This manifests as a failure in
aarch64-none-linux-gnu testing:
FAIL: gcc.dg/torture/builtin-cproj-1.c -Og -g (test for excess errors)
This test does not expect to be called with -Og and will fail if you
do so.
There is a different question about whether we want to enable -Og
testing in dg-torture.exp , in which case this test will need patched
up. But regardless of that decision, advsimd-intrinsics.exp should
not clobber the set-torture-options without good reason.
Fixed by wrapping the main loop of advsimd-intrinsics.exp in torture-init
and torture-finish.
Tested with an aarch64-none-linux-gnu cross build to ensure it
clears the issue I was seeing.
Applied as revision 224507.
Thanks,
James
---
2015-06-16 James Greenhalgh <james.greenhalgh@arm.com>
* gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp:
Reinstate calls to torture-init and torture-finalize.
diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
index f57da39..ceada83 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
@@ -49,6 +49,7 @@ if {[istarget arm*-*-*]} then {
set dg-do-what-default run
}
+torture-init
set-torture-options $C_TORTURE_OPTIONS {{}} $LTO_TORTURE_OPTIONS
# Make sure Neon flags are provided, if necessary.
@@ -60,4 +61,5 @@ gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] \
# All done.
set dg-do-what-default ${save-dg-do-what-default}
+torture-finish
dg-finish