This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[10/13] Require {mark,id}_{deleted,empty} functions
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Tue, 16 Jun 2015 10:11:01 +0100
- Subject: [10/13] Require {mark,id}_{deleted,empty} functions
- Authentication-results: sourceware.org; auth=none
- References: <87fv5s2gej dot fsf at e105548-lin dot cambridge dot arm dot com>
After the previous changes, all traits classes provide an implementation
of the empty & deleted entry functions, so we can remove the code that
provided defaults.
gcc/
* hash-table.h (has_is_deleted, is_deleted_helper): Delete.
(has_is_empty, is_empty_helper): Delete.
(has_mark_deleted, mark_deleted_helper): Delete.
(has_mark_empty, mark_empty_helper): Delete.
(hash_table::is_deleted): Call the Descriptor unconditionally.
(hash_table::is_empty): Likewise.
(hash_table::mark_deleted): Likewise.
(hash_table::mark_empty): Likewise.
Index: gcc/hash-table.h
===================================================================
--- gcc/hash-table.h 2015-06-16 10:10:16.374654332 +0100
+++ gcc/hash-table.h 2015-06-16 10:10:16.370654379 +0100
@@ -323,122 +323,6 @@ hash_table_mod2 (hashval_t hash, unsigne
return 1 + mul_mod (hash, p->prime - 2, p->inv_m2, p->shift);
}
- template<typename Traits>
- struct has_is_deleted
-{
- template<typename U, bool (*)(U &)> struct helper {};
- template<typename U> static char test (helper<U, U::is_deleted> *);
- template<typename U> static int test (...);
- static const bool value = sizeof (test<Traits> (0)) == sizeof (char);
-};
-
-template<typename Type, typename Traits, bool = has_is_deleted<Traits>::value>
-struct is_deleted_helper
-{
- static inline bool
- call (Type &v)
- {
- return Traits::is_deleted (v);
- }
-};
-
-template<typename Type, typename Traits>
-struct is_deleted_helper<Type *, Traits, false>
-{
- static inline bool
- call (Type *v)
- {
- return v == HTAB_DELETED_ENTRY;
- }
-};
-
- template<typename Traits>
- struct has_is_empty
-{
- template<typename U, bool (*)(U &)> struct helper {};
- template<typename U> static char test (helper<U, U::is_empty> *);
- template<typename U> static int test (...);
- static const bool value = sizeof (test<Traits> (0)) == sizeof (char);
-};
-
-template<typename Type, typename Traits, bool = has_is_deleted<Traits>::value>
-struct is_empty_helper
-{
- static inline bool
- call (Type &v)
- {
- return Traits::is_empty (v);
- }
-};
-
-template<typename Type, typename Traits>
-struct is_empty_helper<Type *, Traits, false>
-{
- static inline bool
- call (Type *v)
- {
- return v == HTAB_EMPTY_ENTRY;
- }
-};
-
- template<typename Traits>
- struct has_mark_deleted
-{
- template<typename U, void (*)(U &)> struct helper {};
- template<typename U> static char test (helper<U, U::mark_deleted> *);
- template<typename U> static int test (...);
- static const bool value = sizeof (test<Traits> (0)) == sizeof (char);
-};
-
-template<typename Type, typename Traits, bool = has_is_deleted<Traits>::value>
-struct mark_deleted_helper
-{
- static inline void
- call (Type &v)
- {
- Traits::mark_deleted (v);
- }
-};
-
-template<typename Type, typename Traits>
-struct mark_deleted_helper<Type *, Traits, false>
-{
- static inline void
- call (Type *&v)
- {
- v = static_cast<Type *> (HTAB_DELETED_ENTRY);
- }
-};
-
- template<typename Traits>
- struct has_mark_empty
-{
- template<typename U, void (*)(U &)> struct helper {};
- template<typename U> static char test (helper<U, U::mark_empty> *);
- template<typename U> static int test (...);
- static const bool value = sizeof (test<Traits> (0)) == sizeof (char);
-};
-
-template<typename Type, typename Traits, bool = has_is_deleted<Traits>::value>
-struct mark_empty_helper
-{
- static inline void
- call (Type &v)
- {
- Traits::mark_empty (v);
- }
-};
-
-template<typename Type, typename Traits>
-struct mark_empty_helper<Type *, Traits, false>
-{
- static inline void
- call (Type *&v)
- {
- v = static_cast<Type *> (HTAB_EMPTY_ENTRY);
- }
-};
-
class mem_usage;
/* User-facing hash table type.
@@ -610,23 +494,24 @@ struct mark_empty_helper<Type *, Traits,
value_type *find_empty_slot_for_expand (hashval_t);
void expand ();
static bool is_deleted (value_type &v)
- {
- return is_deleted_helper<value_type, Descriptor>::call (v);
- }
+ {
+ return Descriptor::is_deleted (v);
+ }
+
static bool is_empty (value_type &v)
- {
- return is_empty_helper<value_type, Descriptor>::call (v);
- }
+ {
+ return Descriptor::is_empty (v);
+ }
static void mark_deleted (value_type &v)
- {
- return mark_deleted_helper<value_type, Descriptor>::call (v);
- }
+ {
+ Descriptor::mark_deleted (v);
+ }
static void mark_empty (value_type &v)
- {
- return mark_empty_helper<value_type, Descriptor>::call (v);
- }
+ {
+ Descriptor::mark_empty (v);
+ }
/* Table itself. */
typename Descriptor::value_type *m_entries;