This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][PR debug/65549] Restore DW_AT_abstract_origin for cross-unit call sites
- From: Richard Biener <rguenther at suse dot de>
- To: Pierre-Marie de Rodat <derodat at adacore dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 11 Jun 2015 09:47:58 +0200 (CEST)
- Subject: Re: [PATCH][PR debug/65549] Restore DW_AT_abstract_origin for cross-unit call sites
- Authentication-results: sourceware.org; auth=none
- References: <55775CDE dot 2060101 at adacore dot com> <alpine dot LSU dot 2 dot 11 dot 1506100855090 dot 30088 at zhemvz dot fhfr dot qr> <55783717 dot 8060505 at adacore dot com> <alpine dot LSU dot 2 dot 11 dot 1506101526280 dot 30088 at zhemvz dot fhfr dot qr> <55784A03 dot 2000208 at adacore dot com>
On Wed, 10 Jun 2015, Pierre-Marie de Rodat wrote:
> On 06/10/2015 03:36 PM, Richard Biener wrote:
> > Hmm, yes. It meant to break after the first ;) (without LTO
> > there usually is only one TU decl, apart from Java I think).
> > The hunk isn't in mainline because it was part of an experimental patch I
> > did on the early-debug branch.
>
> Understood, thanks!
>
> > Yeah, that looks great!
> >
> > Of course I wonder about Java (builds multiple ones, one for each
> > input file) and Go (no idea). I suppose Java would need to build
> > another one where all the "defaults" go (or it doesn't have any
> > such entities).
>
> Yeah, I'm not familiar with them neither...
>
> > In theory we could have changed dwarf2out_init to get a
> > translation-unit-decl argument as well. But your patch looks like
> > we don't have such at the point of dwarf2out_init in all frontends.
> >
> > Your patch is ok (and ok to backport) IMHO, though please give
> > others the chance to chime in.
>
> Thank you very much. :-) I will soon become unavailable until July, so I think
> I'll wait until then to commit anyway.
Ok - can you please open a bugreport for the regression on the 4.9
branch so we don't miss the fix for the next 4.9 release which should
be in about 3 weeks from now (in fact you might miss the RC deadline
for that release).
So I suggest you commit the patch to trunk this week so others can
take care of backporting.
Thanks,
Richard.
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)