This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] respin (5th)
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: Christian Bruel <christian dot bruel at st dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>
- Date: Tue, 09 Jun 2015 11:04:44 +0100
- Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [6/6] respin (5th)
- Authentication-results: sourceware.org; auth=none
- References: <554A253A dot 4080905 at st dot com> <5559A5B4 dot 7050007 at st dot com>
Hi Christian,
On 18/05/15 09:41, Christian Bruel wrote:
On 05/06/2015 04:29 PM, Christian Bruel wrote:
>Implement the -mflip-thump option. Undocumented for internal testing
>only. This option artificially inserts alternative attribute thumb/modes
>on functions.
>
>This close the patch set. Thanks for your review,
>
>Christian
>
to close the series. redo patch rebased.
<snip>
static bool
diff '--exclude=.svn' -ruN gnu_trunk.p5/gcc/gcc/config/arm/arm.opt gnu_trunk.p6/gcc/gcc/config/arm/arm.opt
--- gnu_trunk.p5/gcc/gcc/config/arm/arm.opt 2015-05-18 10:20:26.545835080 +0200
+++ gnu_trunk.p6/gcc/gcc/config/arm/arm.opt 2015-05-13 13:13:11.014686529 +0200
@@ -122,6 +122,10 @@
EnumValue
Enum(float_abi_type) String(hard) Value(ARM_FLOAT_ABI_HARD)
+mflip-thumb
+Target Report Var(TARGET_FLIP_THUMB)
+Switch ARM/Thumb modes on alternating functions for compiler testing
How about adding 'Undocumented' to the properties here?
Can we also get a test or two just to sanity check the option?
Otherwise the patch looks ok to me.
Thanks,
Kyrill