This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,gomp4] remove gwv test case
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 18 May 2015 17:01:36 +0200
- Subject: Re: [patch,gomp4] remove gwv test case
- Authentication-results: sourceware.org; auth=none
- References: <5559FDD2 dot 2080205 at codesourcery dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, May 18, 2015 at 07:57:22AM -0700, Cesar Philippidis wrote:
> This patch removes the libgomp.oacc-c/gwv.c. test case. The original
> idea behind this test was to allow us to create our own parallel loops
> using by using the gang, worker and vector threads directly by using the
> built-in GOACC_ thread functions. This test was supposed to ensure that
> those functions work.
>
> Now that we're working on a proper execution model, exposing those
> functions to the end user doesn't make much sense. That's at least true
> for workers and vectors because they start off in worker-single and
> vector-single mode, respectively. Then there's the other issue of
> variable broadcasting. As a result, this test case isn't necessary going
> forward. Those thread functions are already being exercised by omp-low
> for each acc loop anyway.
>
> Cesar
> 2015-05-18 Cesar Philippidis <cesar@codesourcery.com>
>
> libgomp/
> * testsuite/libgomp.oacc-c/gwv.c: Delete.
Ok with me.
Jakub