This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fortran/66052 -- Prevent dereference of NULL pointer
- From: Mikael Morin <mikael dot morin at sfr dot fr>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>, fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sat, 16 May 2015 13:58:30 +0200
- Subject: Re: [PATCH] fortran/66052 -- Prevent dereference of NULL pointer
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header dot from=mikael dot morin at sfr dot fr
- References: <20150515151915 dot GG82729 at troutmask dot apl dot washington dot edu>
Le 15/05/2015 17:19, Steve Kargl a écrit :
> Regression tested on trunk. OK to commit?
>
Hello,
> Index: gcc/fortran/decl.c
> ===================================================================
> --- gcc/fortran/decl.c (revision 223094)
> +++ gcc/fortran/decl.c (working copy)
> @@ -6968,7 +6968,8 @@ gfc_match_protected (void)
> gfc_symbol *sym;
> match m;
>
> - if (gfc_current_ns->proc_name->attr.flavor != FL_MODULE)
> + if (gfc_current_ns->proc_name
> + && gfc_current_ns->proc_name->attr.flavor != FL_MODULE)
> {
> gfc_error ("PROTECTED at %C only allowed in specification "
> "part of a module");
Wouldn't one get a slightly better error message if using
!gfc_current_ns->proc_name
|| gfc_current_ns->proc_name->attr.flavor != FL_MODULE
as condition ?
OK with that change. Thanks.
Mikael