This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, "Martin Sebor" <msebor at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, "Jason Merrill" <jason at redhat dot com>
- Date: Fri, 8 May 2015 09:38:27 -0700
- Subject: Re: [C/C++ PATCH] Implement -Wshift-negative-value (PR c/65179)
- Authentication-results: sourceware.org; auth=none
- References: <20150507191532 dot GH3384 at redhat dot com>
- Reply-to: <sellcey at imgtec dot com>
On Thu, 2015-05-07 at 21:15 +0200, Marek Polacek wrote:
> On Thu, May 07, 2015 at 12:00:20PM -0600, Jeff Law wrote:
> > OK. Please install if you haven't already.
>
> I have not, so will do momentarily. Thanks,
>
> Marek
Marek,
This patch has broken the glibc build. I am not sure if the problem is
a bug in your patch or a bug in the code used by glibc. Here is a
cutdown test case from glibc (timezone/scheck.c). This code compiled
before your patch but now it fails with:
x.c:4:3: error: initializer element is not constant
((((time_t) -1) < 0)
__extension__ typedef long int __time_t;
typedef __time_t time_t;
static time_t const time_t_min =
((((time_t) -1) < 0)
? (time_t) -1 << (8 * sizeof (time_t) - 1)
: 0)
Steve Ellcey
sellcey@imgtec.com