This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 0/13] Add musl support to GCC

From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
To: Jeff Law <law at redhat dot com>, Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, Joseph Myers <joseph at codesourcery dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Gregor Richards <gregor dot richards at uwaterloo dot ca>, Rich Felker <dalias at libc dot org>, Szabolcs Nagy <nsz at port70 dot net>
Date: Fri, 08 May 2015 09:31:35 +0100
Subject: Re: [PATCH 0/13] Add musl support to GCC
Authentication-results: sourceware.org; auth=none
References: <55354A4A dot 4060702 at arm dot com> <alpine dot DEB dot 2 dot 10 dot 1504282326010 dot 10303 at digraph dot polyomino dot org dot uk> <5540DDDC dot 9020005 at arm dot com> <alpine dot DEB dot 2 dot 10 dot 1504292317341 dot 17007 at digraph dot polyomino dot org dot uk> <5549FCA6 dot 2020302 at arm dot com> <554BA9DC dot 7030903 at redhat dot com>


On 07/05/15 19:07, Jeff Law wrote:

On 05/06/2015 05:36 AM, Szabolcs Nagy wrote:

On 30/04/15 00:18, Joseph Myers wrote:

On Wed, 29 Apr 2015, Szabolcs Nagy wrote:

only affects [u]int_fastN_t types
(on 64bit systems for N=16,32 musl uses int but glibc uses long)

i can fix glibc-stdint.h, but it's yet another way in which the
compiler is tied to a particular libc.

...

(i'd prefer if the compiler did not know about these types, but

...

The compiler also needs to know these types for the Fortran C bindings.

This is a work around patch so -mmusl or default musl libc
changes the [U]INT_FAST{16,32}_TYPE macro definitions.

The undef/define logic is needed because glibc-stdint.h is
used on non-linux targets where OPTION_MUSL would not be
defined and it is used both before and after config/linux.h on
various linux targets.

I did not find any cleaner workaround. (Separate musl-stdint.h
would need significant changes in config.gcc.)

gcc/Changelog:

2015-05-06  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	* config/glibc-stdint.h (OPTION_MUSL): Define.
	(INT_FAST16_TYPE, INT_FAST32_TYPE, UINT_FAST16_TYPE, UINT_FAST32_TYPE):
	Change the definition based on OPTION_MUSL for 64 bit targets.

	* config/linux.h (OPTION_MUSL): Redefine.
	* config/alpha/linux.h (OPTION_MUSL): Redefine.
	* config/rs6000/linux.h (OPTION_MUSL): Redefine.
	* config/rs6000/linux64.h (OPTION_MUSL): Redefine.

I really don't like the MUSL bits inside glibc-stdint.h.  But I don't
see an easy way to avoid it.

OK for the trunk.


I've committed this on Szabolcs' behalf with r222905.

Kyrill


jeff

References:
- Re: [PATCH 0/13] Add musl support to GCC
  - From: Szabolcs Nagy
- Re: [PATCH 0/13] Add musl support to GCC
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]