This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
- From: "rohitarulraj at freescale dot com" <rohitarulraj at freescale dot com>
- To: Jeff Law <law at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "rguenther at suse dot de" <rguenther at suse dot de>, "Jakub Jelinek" <jakub at redhat dot com>
- Cc: Alan Modra <amodra at gmail dot com>, David Edelsohn <dje dot gcc at gmail dot com>, "Edmar Wienskoski" <edmar at freescale dot com>, "rohitarulraj at freescale dot com" <rohitarulraj at freescale dot com>
- Date: Thu, 30 Apr 2015 15:34:24 +0000
- Subject: RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;
- References: <BLUPR03MB14584D4240675B763002EA5FC2090 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <BLUPR03MB1458002E9FF7B37BD72093E5C2E80 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <553FCEC6 dot 8030609 at redhat dot com> <BLUPR03MB14580D7A857EC224F78FCBAFC2E80 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <55400A0E dot 5010601 at redhat dot com> <BLUPR03MB14580146D1439BC971C101C9C2D70 at BLUPR03MB1458 dot namprd03 dot prod dot outlook dot com> <554243E9 dot 6030206 at redhat dot com>
> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: Thursday, April 30, 2015 8:32 PM
> To: Dharmakan Rohit-B30502; gcc-patches@gcc.gnu.org;
> rguenther@suse.de; Jakub Jelinek
> Cc: Alan Modra; David Edelsohn; Wienskoski Edmar-RA8797
> Subject: Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value
> to output_constant_pool_2
>
> On 04/29/2015 04:30 AM, rohitarulraj@freescale.com wrote:
> >>
> >
> > Jeff, I have made the changes as per your comments and attached the
> patch.
> > If the patch is OK, I will proceed with the regression tests.
> This patch refers back to 60158 and based on what I see in 60158, it appears I
> should be looking for a .data.rel.ro.local section which contains the address
> of a string constant. But the constants are being put into .rodata.str1.4. And
> if the issue is we're putting bits into the wrong section and don't have an
> appropriate .fixup section, then ISTM that the test should be compiled, then
> objdump used to verify the sections and/or relocations.
>
> An additional concern is that I get the same code for the included testcase
> with or without your changes. This is with a powerpc-softfloat-linux-gnuspe
> configured compiler -- which matches what I saw in pr 60158.
>
> So while the patch seems reasonable, I'm concerned that I've been unable to
> show it changing anything.
>
> Thoughts?
>
Jeff, the issue is still reproducible with GCC v4.8 branch but not with GCC v4.9 or trunk.
Regards,
Rohit