This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: c-family PATCH to improve -Wbool-compare (PR c/64610)
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Apr 2015 11:42:18 +0200
- Subject: Re: c-family PATCH to improve -Wbool-compare (PR c/64610)
- Authentication-results: sourceware.org; auth=none
- References: <20150428104932 dot GD11448 at redhat dot com>
Marek Polacek <polacek@redhat.com> writes:
> PR c/64610
> * c-common.c (maybe_warn_bool_compare): Warn when comparing a boolean
> with 0/1.
/usr/local/gcc/gcc-20150430/Build/./prev-gcc/xg++ -B/usr/local/gcc/gcc-20150430/Build/./prev-gcc/ -B/usr/aarch64-suse-linux/bin/ -nostdinc++ -B/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/src/.libs -B/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/libsupc++/.libs -I/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/include/aarch64-suse-linux -I/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/include -I/usr/local/gcc/gcc-20150430/libstdc++-v3/libsupc++ -L/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/src/.libs -L/usr/local/gcc/gcc-20150430/Build/prev-aarch64-suse-linux/libstdc++-v3/libsupc++/.libs -c -g -O2 -gtoggle -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc -I../../gcc/. -I../../gcc/../include -I../../gcc/../libcpp/include -I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/../libbacktrace -o expr.o -MT expr.o -MMD -MP -MF ./.deps/expr.TPo ../../gcc/expr.c
../../gcc/expr.c: In function 'int can_store_by_pieces(long unsigned int, rtx_def* (*)(void*, long int, machine_mode), void*, unsigned int, bool)':
../../gcc/expr.c:2496:16: error: comparison of constant 'true' with boolean expression is always true [-Werror=bool-compare]
reverse <= (HAVE_PRE_DECREMENT || HAVE_POST_DECREMENT);
^
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."