This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook
- From: "Bin.Cheng" <amker dot cheng at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Christian Bruel <christian dot bruel at st dot com>, Richard Henderson <rth at redhat dot com>, Jan Hubicka <hubicka at ucw dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Apr 2015 16:27:05 +0800
- Subject: Re: [PATCH, x86] Add TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE hook
- Authentication-results: sourceware.org; auth=none
- References: <54D21CD9 dot 7040201 at st dot com> <CAFULd4bXwaBH13E-0=v8ArVsNUimrgNiojcdF-t3LE7Nk6vueQ at mail dot gmail dot com>
On Mon, Apr 27, 2015 at 8:01 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Wed, Feb 4, 2015 at 2:21 PM, Christian Bruel <christian.bruel@st.com> wrote:
>> While trying to reduce the PR64835 case for ARM and x86, I noticed that the
>> alignment flags are cleared for x86 when attribute optimized is used.
>>
>> With the attached testcases, the visible effects are twofold :
>>
>> 1) Functions compiled in with attribute optimize (-O2) are not aligned as if
>> they were with the -O2 flag.
>>
>> 2) can_inline_edge_p fails because opts_for_fn (caller->decl) != opts_for_fn
>> (callee->decl)) even-though they are compiled with the same optimization
>> level.
>
> 2015-02-06 Christian Bruel <christian.bruel@st.com>
>
> PR target/64835
> * config/i386/i386.c (ix86_default_align): New function.
> (ix86_override_options_after_change): Call ix86_default_align.
> (TARGET_OVERRIDE_OPTIONS_AFTER_CHANGE): New hook.
> (ix86_override_options_after_change): New function.
>
> 2015-02-06 Christian Bruel <christian.bruel@st.com>
>
> PR target/64835
> * gcc.dg/ipa/iinline-attr.c: New test.
> * gcc.target/i386/iinline-attr-2.c: New test.
>
> OK for mainline.
Hi Christian,
I noticed case gcc.dg/ipa/iinline-attr.c failed on aarch64. The
original patch is x86 specific, while the case is added as general
one. Could you please have a look at this?
FAIL: gcc.dg/ipa/iinline-attr.c scan-ipa-dump inline
"hooray[^\\n]*inline copy in test"
Thanks,
bin
>
> Thanks,
> Uros