This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gimple-walk.c #include TLC
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 29 Apr 2015 12:46:17 +0200
- Subject: Re: [PATCH] gimple-walk.c #include TLC
- Authentication-results: sourceware.org; auth=none
- References: <1430294510-18361-1-git-send-email-rep dot dot dot nop at gmail dot com> <1430294510-18361-2-git-send-email-rep dot dot dot nop at gmail dot com> <CAFiYyc0BoX8Cbyt4vO_FfYP91QxzNqwjfWsUiehVW-4otRArLg at mail dot gmail dot com>
On 29 April 2015 at 11:00, Richard Biener <richard.guenther@gmail.com> wrote:
> On Wed, Apr 29, 2015 at 10:01 AM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> Hi there,
>>
>> I noticed that gimple-walk.c has a creative list of #includes.
>> Furthermore, in walk_gimple_asm parse_{in,out}put_constraint was called
>> even if neither allows_mem, allows_reg nor is_inout were used -- i.e. if
>> wi is NULL -- and the return value of the constraint parsing was not
>> taken into account which looks wrong or at least odd. Note that several
>> other spots in the tree do ignore the parse_{in,out}put_constraint return
>> values and should be adjusted too AFAIU. Otherwise we might attempt
>> (and use!) to extract information from otherwise illegal constraints,
>> it seems?
>>
>> Bootstrapped and regtested on x86_64-unknown-linux with no regressions.
>> Ok for trunk?
>
> Ok.
r222569.
Thanks!