This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Michael Meissner <meissner at linux dot vnet dot ibm dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Fri, 24 Apr 2015 10:34:30 -0500
- Subject: Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- Authentication-results: sourceware.org; auth=none
- References: <1426879660 dot 13627 dot 71 dot camel at otta> <20150320205200 dot GA32613 at gate dot crashing dot org> <1426891319 dot 13627 dot 101 dot camel at otta> <1429649778 dot 21947 dot 25 dot camel at otta> <20150422021759 dot GC23315 at gate dot crashing dot org> <1429710190 dot 21947 dot 48 dot camel at otta> <20150422221633 dot GA29172 at gate dot crashing dot org> <1429816564 dot 21947 dot 110 dot camel at otta>
On Thu, Apr 23, 2015 at 02:16:04PM -0500, Peter Bergner wrote:
> Ok, I created a separate ttest define_insn that hard codes the operands.
> I switched to using r1 rather than r0 as the second operand, for the
> reason that there could be code that sets r0 directly before this insn
> and I didn't want to create a unneeded read-after-write dependency.
> I thought r1 should be safe to use, since it's only updated in the
> prologue/epilogue and should be constant for the life of the function.
GPR1 is very likely already read before as well :-)
> > Maybe just { powerpc64 } works?
>
> powerpc64 doesn't work. It tells us whether the target will execute
> 64-bit instructions or not.
Ah yes, it is more like a "powerpc64_hw". Oh well.
All looks great to me now, thanks for the changes,
Segher
- References:
- Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state
- Re: [PATCH, rs6000, testsuite] Fix PR target/64579, __TM_end __builtin_tend failed to return transactional state