This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [1/2] [ARM] [libgcc] Support RTABI half-precision conversion functions.
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Hale Wang <hale dot wang at arm dot com>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, Joseph Myers <joseph at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 22 Apr 2015 09:59:44 +0100
- Subject: Re: [PATCH] [1/2] [ARM] [libgcc] Support RTABI half-precision conversion functions.
- Authentication-results: sourceware.org; auth=none
- References: <000601d07346$9fbec910$df3c5b30$ at arm dot com> <alpine dot DEB dot 2 dot 10 dot 1504102024540 dot 6902 at digraph dot polyomino dot org dot uk> <001301d075c0$d1ec2870$75c47950$ at arm dot com> <alpine dot DEB dot 2 dot 10 dot 1504131123090 dot 5026 at digraph dot polyomino dot org dot uk> <CAJA7tRZoa=kKJr1yReNqOH_+iWWsyV7FS6UwRkWRWycyADbVng at mail dot gmail dot com> <003f01d07cd6$dfe05150$9fa0f3f0$ at arm dot com>
- Reply-to: ramrad01 at arm dot com
On Wed, Apr 22, 2015 at 9:32 AM, Hale Wang <hale.wang@arm.com> wrote:
>> -----Original Message-----
>> From: Ramana Radhakrishnan [mailto:ramana.gcc@googlemail.com]
>> Sent: Wednesday, April 22, 2015 3:50 PM
>> To: Joseph Myers
>> Cc: Hale Wang; GCC Patches
>> Subject: Re: [PATCH] [1/2] [ARM] [libgcc] Support RTABI half-precision
>> conversion functions.
>>
>> On Mon, Apr 13, 2015 at 12:25 PM, Joseph Myers
>> <joseph@codesourcery.com> wrote:
>> > On Mon, 13 Apr 2015, Hale Wang wrote:
>> >
>> >> Yes, you are right. It's my fault to add the "only" here. Thank you
>> >> to point out this.
>> >> Beside this, is this patch OK for you?
>> >
>> > I don't think it's a good idea for libgcc to include large pieces of
>> > assembly code generated by a compiler. Just compile the code with
>> > whatever options are needed at the time libgcc is built - possibly
>> > with #if conditionals to allow compiling different versions of the code.
>
> Indeed, just compile the code with option '-mfloat-abi=soft' at the time libgcc is build which can solve this problem.
Or why not "conditionally" use the ``pcs'' attribute on the ARM port ?
That then means you don't need options magic on top ?
Ramana