This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Optionally sanitize globals in user-defined sections
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: Andi Kleen <andi at firstfloor dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Andrey Ryabinin <a dot ryabinin at samsung dot com>, Dmitry Vyukov <dvyukov at google dot com>
- Date: Sun, 19 Apr 2015 17:11:42 +0200
- Subject: Re: [PATCH] Optionally sanitize globals in user-defined sections
- Authentication-results: sourceware.org; auth=none
- References: <5530B739 dot 5000306 at samsung dot com> <5530B84E dot 7030709 at samsung dot com> <87vbgu1x4d dot fsf at tassilo dot jf dot intel dot com> <55335F51 dot 3080900 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sun, Apr 19, 2015 at 10:54:57AM +0300, Yury Gribov wrote:
> On 04/17/2015 08:29 PM, Andi Kleen wrote:
> >Yury Gribov <y.gribov@samsung.com> writes:
> >>+
> >>+static bool
> >>+section_sanitized_p (const char *sec)
> >>+{
> >>+ if (!sanitized_sections)
> >>+ return false;
> >>+ size_t len = strlen (sec);
> >>+ const char *p = sanitized_sections;
> >>+ while ((p = strstr (p, sec)))
> >>+ {
> >>+ if ((p == sanitized_sections || p[-1] == ',')
> >>+ && (p[len] == 0 || p[len] == ','))
> >>+ return true;
> >
> >No wildcard support? That may be a long option in some cases.
>
> Right. Do you think * will be enough or we also need ? and [a-f] syntax?
libiberty contains and gcc build utilities already use fnmatch, so you
should just use that (with carefully chosen FNM_* options).
Jakub