Re: [C++ Patch] PR 65340

[Jason Merrill <jason at redhat dot com>]

On 03/17/2015 10:15 PM, Jason Merrill wrote:
> On 03/17/2015 10:03 PM, Paolo Carlini wrote:
> > On 03/18/2015 01:11 AM, Jason Merrill wrote:

> > > Are there other places that still need to pass complain to mark_used?
> > Well, if we are talking about functions getting a tsubst_flags_t and
> > *not* passing it down to mark_used, there are quite a few - see
> > attached. I didn't feel like raising the issue at this time because in
> > all those cases, at variance with the specific case we are changing for
> > the bug, the return value of mark_used is *not* checked, thus is we
> > suppress the errors in SFINAE context we would like to also add a check
> > and return early, but in general, doing that when we are *outside*
> > SFINAE changes what happens during error recovery, thus it seems a bit
> > risky fiddling with those right now...
>
> Agreed, let's defer this until stage 1.

I note that it's now stage 1.  :)

There are various places in the compiler that error and continue if 
tf_error is set, but return error_mark_node immediately if not; it seems 
reasonable to follow that pattern in the places that don't currently 
check the return value.

Jason