This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR target/65602] Fix check_effective_target_mpx to check lib availability
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 31 Mar 2015 11:27:35 +0300
- Subject: Re: [PATCH, PR target/65602] Fix check_effective_target_mpx to check lib availability
- Authentication-results: sourceware.org; auth=none
- References: <20150330140033 dot GB52842 at msticlxl57 dot ims dot intel dot com> <5519ADCA dot 6080704 at redhat dot com> <yddiodikz2j dot fsf at CeBiTec dot Uni-Bielefeld dot DE>
2015-03-30 23:30 GMT+03:00 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> I originally reported the bug and did test the patch over the weekend:
> the Solaris/x86 testsuite failures are gone, so that part is fine. I
> couldn't of course test the alloca -> __builtin_alloca change since the
> tests aren't built at all.
>
> I don't have a baseline for Linux/x86_64 without --enable-libmpx (the
> default) to compare against, but see in the gcc.log file that the mpx
> tests aren't run in that config due to missing -lmpx -lmpxwrappers.
Thanks for testing!
>
> I'd suggest (though this is stage1 material) to split the mpx tests into
> compile (requiring an assembler with mpx support) and link/run
> (also requiring the runtime libs) tests to extend test coverage.
I don't see much reason to run compile mpx tests on targets where mpx
is not supported. I thinks it would be enough to just enable libmpx by
default on stage 1.
Thanks
Ilya
>
> Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University