This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 27 Mar 2015 17:56:39 +0100
- Subject: Re: [PATCH] PR target/65248: Copy relocation against protected symbol doesn't work
- Authentication-results: sourceware.org; auth=none
- References: <20150306013151 dot GA19444 at intel dot com> <20150306134217 dot GA21141 at intel dot com> <CAFULd4bjUGRunFtepHF+cTOeX06J2boL2XTs1dnThAtPx2SAJA at mail dot gmail dot com> <91A78199-CD95-4074-8FD3-72D193898EDF at comcast dot net> <CAMe9rOqm6vfD0i50gTRKJYM_==dFmON_3i7RVL=EKr=13FOSJw at mail dot gmail dot com> <CAMe9rOqYhxMO4mmV=rxrFyFjYPhkrrJ0=0vDQvQ1kHxJFQFt5A at mail dot gmail dot com>
On Fri, Mar 27, 2015 at 5:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Mar 18, 2015 at 12:11 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Mar 18, 2015 at 11:58 AM, Mike Stump <mikestump@comcast.net> wrote:
>>> On Mar 18, 2015, at 2:55 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>>>
>>>>> Here is the updated patch with testcases. Tested on Linux/x86. OK
>>>>> for trunk?
>>>
>>>> This patch needs global reviewer approval (I have added Jakub to CC)
>>>> and Darwin maintainer approval.
>>>
>>> So, my concern would be this, does the bug also impact darwin, and does the bug fix also fix darwin?
>>
>> This bug doesn't impact darwin.
>>
>>> If no and the change doesnât change code-gen for darwin (which I think it does not), then the darwin bits are ok.
>>>
>>> I did a quick check of the test case on darwin, no protected variables (we ignore the protected request). When compiled, the program works (returns 0).
>>
>> It is expected. This bug only affects targets which support protected
>> visibility and use copy relocation.
>>
>
> Hi Jakub,
>
> I'd like to fix this bug for GCC 5. Is that OK for trunk:
>
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00325.html
>
> It only impacts Linux/x86.
Jakub, does the patch look OK to you? I am not that familiar with this
part of the code ...
Uros.