This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 23 Mar 2015 12:57:02 +0100
- Subject: Re: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- Authentication-results: sourceware.org; auth=none
- References: <000501d049d3$079385a0$16ba90e0$ at arm dot com> <CABu31nMdEDzr_mPvZvN=zuLMmGRDBP3wDb-6FLX2xUz13Qn2fw at mail dot gmail dot com> <000601d04a5c$a0c0f030$e242d090$ at arm dot com> <CABu31nO-FyF_T3KCv1PW-ndAotCKdxpjzROm7kjTEb5p2DEt3A at mail dot gmail dot com> <000001d062e8$ece63930$c6b2ab90$ at arm dot com> <000101d062f8$68a35350$39e9f9f0$ at arm dot com> <CABu31nMq-md5ZRAovEzcOM8tPYH8GJZn-pb6tQTPJcHA=F=zjg at mail dot gmail dot com> <000201d06558$acd8a130$0689e390$ at arm dot com>
On Mon, Mar 23, 2015 at 12:01 PM, Thomas Preud'homme wrote:
> What about the cprop_reg_p that needs to be negated? Did I miss something
> that makes it ok?
You didn't miss anything. I sent the wrong patch. The one I tested on
ppc64 also has the condition reversed:
@@ -1328,9 +1329,8 @@ implicit_set_cond_p (const_rtx cond)
if (GET_CODE (cond) != EQ && GET_CODE (cond) != NE)
return false;
- /* The first operand of COND must be a pseudo-reg. */
- if (! REG_P (XEXP (cond, 0))
- || HARD_REGISTER_P (XEXP (cond, 0)))
+ /* The first operand of COND must be a register we can propagate. */
+ if (! cprop_reg_p (XEXP (cond, 0)))
return false;
/* The second operand of COND must be a suitable constant. */
- References:
- Re: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- RE: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- RE: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- Re: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
- RE: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible