This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR ipa/65432
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin LiÅka <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>, Markus Trippelsdorf <markus at trippelsdorf dot de>
- Date: Wed, 18 Mar 2015 14:33:27 +0100
- Subject: Re: [PATCH] Fix PR ipa/65432
- Authentication-results: sourceware.org; auth=none
- References: <55097C8A dot 80002 at suse dot cz>
On Wed, Mar 18, 2015 at 2:24 PM, Martin LiÅka <mliska@suse.cz> wrote:
> Hello.
>
> Following patch wraps symtab_node::{asm_}name with xstrdup_for_dump.
>
> Ready for trunk?
/* Gets symbol name of the item. */
const char *name (void)
{
- return node->name ();
+ return xstrdup_for_dump (node->name ());
shouldn't the methods be called dump_name () then? And why's
node->name () not already dup-ing the string?
That said, I wonder where we use ->name / ->asm_name. And why
that's different for ICF.
The patch would be more obvious if all fixes were to dumping sites.
Richard.
> Thanks,
> Martin