This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING^2] [PATCH] [AArch64, NEON] Improve vmulX intrinsics
- From: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- To: Jiangjiji <jiangjiji at huawei dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "Yangfei (Felix)" <felix dot yang at huawei dot com>
- Date: Thu, 12 Mar 2015 11:44:47 +0000
- Subject: Re: [PING^2] [PATCH] [AArch64, NEON] Improve vmulX intrinsics
- Authentication-results: sourceware.org; auth=none
- References: <B34C25384B9D7A428FF276D3AE7D6BDC7B4FE913 at nkgeml511-mbx dot china dot huawei dot com>
Hi Jiangjiji,
This is definitely stage 1 material by now...
At my glance it all looks like the right approach, I have a question below:
On 12/03/15 09:20, Jiangjiji wrote:
+
+(define_insn "aarch64_fmulx_lane<mode>"
+ [(set (match_operand:VDQF 0 "register_operand" "=w")
+ (unspec:VDQF [(match_operand:VDQF 1 "register_operand" "w")
+ (match_operand:<VDQF_Q> 2 "register_operand" "w")
+ (match_operand:SI 3 "immediate_operand" "i")]
+ UNSPEC_FMULX_LANE))]
+ "TARGET_SIMD"
+ "fmulx\\t%0.<vtype>, %1.<vtype>, %2.<vetype>"
+ [(set_attr "type" "neon_mul_s")]
+)
Where did operand 3 go? Shouldn't his be the lane-element variant of fmulx?
Thanks,
Kyrill