On 03/02/15 09:28, Martin Sebor wrote:
On 03/02/2015 06:58 AM, Richard Biener wrote:
On Fri, 27 Feb 2015, Martin Sebor wrote:
Given that Martin's fix to the testcase allowed it to succeed without
Richi's fix for the underlying problem, is there a modification to
the
testcase or a new testcase that would really test the optimization?
Let me work on it.
Below is a patch with a couple of minor tweaks to the existing
test first to update the search string and second to better
exercise the vectorization not only when the source address
isn't aligned on the expected boundary but also when the
destination address isn't. This enhancement revealed
an outstanding aspect of the regression (not fixed by Richard's
already committed patch).
Besides this change, the patch also adds a number of other
tests to better exercise the vectorization by verifying it
takes place for arrays of elements of other sizes besides
word: byte, half word, and double word. Those tests reveal
both another regression WRT 4.8 and further vectorization
opportunities not exploited even in 4.8. I marked the latter
XFAIL in the tests so that when the regression is fully
resolved, the tests should pass with no unexpected failures.
I have a hard time applying the patch because of line-wrapping issues
or my patch tool not groking the git diffs.
Can you please either commit the patch or extract the testcase
that still regresses and paste it into PR63175?
I pasted a couple of such test cases to the bug. The full patch
is also attached to this email in case there was a problem with
line wrapping.
So for the unaligned case, is that really a regression when compared to
earlier compilers? If not, then it seems that we ought to at least be
at a point where the regression marker for that BZ can be removed,
right? ie, Richi's patch fixed the actual code quality regression and
your patch fixes the testsuite aspects, right?