This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] ICF: move readonly decision for variables to the right place
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: Martin LiÅka <mliska at suse dot cz>, "gcc-pat >> GCC Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 6 Mar 2015 06:38:25 -0800
- Subject: Re: [PATCH] ICF: move readonly decision for variables to the right place
- Authentication-results: sourceware.org; auth=none
- References: <54F25A19 dot 10903 at suse dot cz> <20150301002635 dot GG20437 at kam dot mff dot cuni dot cz> <20150302005756 dot GF1771 at kam dot mff dot cuni dot cz> <20150302075343 dot GA67273 at kam dot mff dot cuni dot cz>
On Sun, Mar 1, 2015 at 11:53 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> this is a variant of patch I commited.
> It takes care to load the constructor to memory in sem_variable::equals
> and donot touch it earlier. I also made sem_variable::parse to skip volatile
> and reigster variables.
>
> Bootstrapped/regtested x86_64-linux, lto-bootstrapped with -fmerge-all-constants
> comitted.
>
> Honza
>
> 2015-02-28 Martin Liska <mliska@suse.cz>
> Jan Hubicka <hubicka@ucw.cz>
>
> * ipa-icf.c (sem_variable::equals): Improve debug output;
> get variable constructor.
> (sem_variable::parse): Do not filter out too early; give up on
> volatile and register vars.
> (sem_item_optimizer::filter_removed_items): Filter out nonreadonly
> variables.
> * ipa-icf.h (sem_variable::init): Do not set ctor.
> (sem_variable::ctor): Remove.
>
This caused:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65334
--
H.J.