This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix PR65048: check that jump-thread paths are still valid
- From: Sebastian Pop <sebpop at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: "Brian M. Rzycki" <brzycki at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 25 Feb 2015 19:18:43 +0000
- Subject: Re: [patch] fix PR65048: check that jump-thread paths are still valid
- Authentication-results: sourceware.org; auth=none
- References: <20150213235033 dot GA20179 at f1 dot c dot bardezibar dot internal> <54E2E67D dot 7030109 at redhat dot com> <20150218222723 dot GA24606 at f1 dot c dot bardezibar dot internal> <54EBB147 dot 2080400 at redhat dot com>
Jeff Law wrote:
> On 02/18/15 15:27, Sebastian Pop wrote:
> >>The dumps for the FSM threads are a bit sparse -- they don't show
> >>the entire path. That makes it much harder to see what's going on.
> >
> >Would a patch improving the FSM dumps ok to commit separately to trunk?
> Most definitely. I realize we're in stage4, but I'd approve such a change.
Attached:
* tree-ssa-threadupdate.c (dump_jump_thread_path): Print all edges
of an EDGE_FSM_THREAD.
I'm regstrapping on x86_64-linux. Ok for trunk if it passes?
Thanks,
Sebastian
>From df583e5d511db2ed87c14cd5290f382c139636d9 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Wed, 25 Feb 2015 20:12:33 +0100
Subject: [PATCH] improve FSM jump thread dump
---
gcc/tree-ssa-threadupdate.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/gcc/tree-ssa-threadupdate.c b/gcc/tree-ssa-threadupdate.c
index 7a41ab2..7a159bb 100644
--- a/gcc/tree-ssa-threadupdate.c
+++ b/gcc/tree-ssa-threadupdate.c
@@ -197,6 +197,9 @@ dump_jump_thread_path (FILE *dump_file, vec<jump_thread_edge *> path,
if (path[i]->type == EDGE_NO_COPY_SRC_BLOCK)
fprintf (dump_file, " (%d, %d) nocopy;",
path[i]->e->src->index, path[i]->e->dest->index);
+ if (path[0]->type == EDGE_FSM_THREAD)
+ fprintf (dump_file, " (%d, %d) ",
+ path[i]->e->src->index, path[i]->e->dest->index);
}
fputc ('\n', dump_file);
}
--
1.7.2.5