This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements

From: Jeff Law <law at redhat dot com>
To: Jack Howarth <howarth dot at dot gcc at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 16 Feb 2015 12:11:53 -0700
Subject: Re: [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements
Authentication-results: sourceware.org; auth=none
References: <54DE6884 dot 9060704 at redhat dot com> <CAMe9rOrN=Nmu7=bhbEnNdR4C2CpaDf_e4H1mN_yLY9g5L+FUrw at mail dot gmail dot com> <CAJMcOU8y_wVWAZhMhcx+UxiTL2uc2g2TNFYuPP8GovJMCmaA+A at mail dot gmail dot com>

On 02/13/15 23:12, Jack Howarth wrote:

This also breaks the bootstrap on x86_64-apple-darwin14 due to a
similar stage 2/3 comparison failure.

Thanks. I'm pretty sure I've got the root cause of both of thesefailures. There's a gsi_last_bb in some existing code that really needsto be changed into gsi_last_nondebug_bb.

It didn't matter before because a block ending in debug statements wasnever considered potentially threadable by VRP. However it matters withmy change because we're allowing threading through such blocks. Strangethat it didn't show up in my tests. But it's definitely a real issue.


Jeff

References:
- [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements
  - From: Jeff Law
- Re: [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements
  - From: H.J. Lu
- Re: [PATCH][PR tree-optimization/64823] Handle threading through blocks with PHIs, but no statements
  - From: Jack Howarth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]