This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Handle typedef name as a flexible array member (PR c/64768)
- From: Marek Polacek <polacek at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 14 Feb 2015 12:26:14 +0100
- Subject: Re: [C PATCH] Handle typedef name as a flexible array member (PR c/64768)
- Authentication-results: sourceware.org; auth=none
- References: <20150213184540 dot GC23138 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1502132051380 dot 23284 at digraph dot polyomino dot org dot uk>
On Fri, Feb 13, 2015 at 08:53:38PM +0000, Joseph Myers wrote:
> On Fri, 13 Feb 2015, Marek Polacek wrote:
>
> > Since we had no testing for such cases whatsoever, I took existing flexible
> > array member tests and duplicated them, only adjusted them to use a typedef
> > name, so that we test as many scenarios as possible - I think this ought to
> > give us a reasonable level of confidence that this works as expected now.
> >
> > Bootstrapped/regtested on {ppc64,x86_64}-linux, ok for trunk?
>
> OK, though the use of
>
> /* { dg-bogus "warning" "warning in place of error" } */
>
> is a relic of when dg-error / dg-warning used not to verify that
> diagnostics were in fact errors / warnings; now they do check that, simply
> using dg-error (on the line with the diagnostic, so not needing { target
> *-*-* } and a line number) suffices rather than needing such a dg-bogus /
> dg-error pair.
Thanks, I've fixed that up and committed the patch.
Marek