Re: [Patch ARM] Improve guality tests - part 1 - pr36728-1.c

[Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>]

On 04/02/2015 11:10, Jakub Jelinek wrote:
> On Wed, Feb 04, 2015 at 11:03:29AM +0000, Ramana Radhakrishnan wrote:
> > > Changelog:
> > >
> > > * gcc.dg/guality/pr36728-1.c: Skip some tests for arm.
> >
> > Segher and I discussed an alternative approach - marking these as "m"
> > (arg1) , "m" (arg2) .... etc in the asm blocks also gives us the same
> > effect and then probably removes the need to rely on such target
> > markers.  I've just noticed that the AArch64 port has the same issues.
>
> I don't think it is a good idea to significantly change the function being
> tested.  Then it tests completely different thing from what it is meant to
> test.
> But in the pr36728-{1,2}.c case, perhaps you could instead change the
> caller, by adding
>    asm volatile ("" : : "r" (l));
> before return 0; in main, that way DW_OP_GNU_entry_value could work if there
> is no other way to find the value of the arguments, because l will need to
> live somewhere (in some register or memory) across the foo call.

That's more elegant than marking them all as "used" - I didn't know 
about the DW_OP_GNU_entry_value extension. Pretty neat now that I've 
read about it. It seems to have fixed up all of these issues here.

I don't have access to s390 so I'm not about to revert the s390 bits in 
this particular case.


<DATE>  Jakub Jelinek  <jakub@redhat.com>
        Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

	* gcc.dg/guality/pr36728-1.c (main): Adjust for targets that pass 
parameters in registers.
	* gcc.dg/guality/pr36728-2.c: Likewise.
	* gcc.dg/guality/pr36728-3.c: Likewise.
	* gcc.dg/guality/pr36728-4.c: Likewise.

regards
Ramana

> 	Jakub

Attachment: pr36728.txt
Description: Text document