This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch, libbacktrace/libsanitizer/libquadmath/libcilkrts] fix multilib builds

From: Jeff Law <law at redhat dot com>
To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>, Matthias Klose <doko at ubuntu dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Paolo Bonzini <bonzini at gnu dot org>, DJ Delorie <dj at redhat dot com>, Nathanael Nerode <neroden at gcc dot gnu dot org>, Alexandre Oliva <aoliva at redhat dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Tobias Burnus <burnus at net-b dot de>, Jakub Jelinek <jakub at redhat dot com>, "Balaji V. Iyer" <balaji dot v dot iyer at intel dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
Date: Mon, 26 Jan 2015 15:16:02 -0700
Subject: Re: [patch, libbacktrace/libsanitizer/libquadmath/libcilkrts] fix multilib builds
Authentication-results: sourceware.org; auth=none
References: <20150126143004 dot GB30813 at physik dot fu-berlin dot de>

On 01/26/15 07:30, Tobias Burnus wrote:

Matthias Klose wrote:

However for the libbacktrace and the libsanitizer builds, the AM_ENABLE_MULTILIB
macro is included way too late.  Scan the generated configure file for
"cross_compiling" and see that the above snippet is added after the failing
checks. The fix seems to be simple, just move the AM_ENABLE_MULTILIB macro up so
that the "cross_compiling" value is corrected before it is tested.  This is what
the patch is doing.

[...]

CCed, and there are more directories needing an update: libquadmath and
libcilkrts.  Note that libcilkrts didn't have an AM_ENABLE_MULTILIB call at all,
but nevertheless builds the multilib libraries.

The attached patch just moves the AM_ENABLE_MULTILIB calls up in the files, so
that these are found before GCC_NO_EXECUTABLES (which is not called in every
libXXdir) and AC_PROC_CC.

x32 multilib enabled x86_64-linux-gnu and i686-linux-gnu configurations built
successfully on a non-x32 enabled kernel.


 From my side, the libquadmath part of patch is okay.

As is the libcilkrts part of the patch.

jeff

References:
- Re: [patch, libbacktrace/libsanitizer/libquadmath/libcilkrts] fix multilib builds
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]