This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Use static chain and libffi for Go closures

From: Richard Henderson <rth at redhat dot com>
To: Andreas Schwab <schwab at linux-m68k dot org>, Ian Lance Taylor <iant at golang dot org>
Cc: Andrew Pinski <pinskia at gmail dot com>, "gofrontend-dev at googlegroups dot com" <gofrontend-dev at googlegroups dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 19 Jan 2015 14:09:53 -0800
Subject: Re: Use static chain and libffi for Go closures
Authentication-results: sourceware.org; auth=none
References: <54B83B61 dot 1010108 at redhat dot com> <m2bnlxwx87 dot fsf at linux-m68k dot org> <54BAB1B5 dot 9010605 at redhat dot com> <87sif9usxk dot fsf at igel dot home> <54BAD370 dot 80402 at redhat dot com> <CA+=Sn1=s9SC5XP5wR2bDVo5fAhDdQcY4vFAaV4j9UJgdx2WB9A at mail dot gmail dot com> <87mw5huktp dot fsf at igel dot home> <CA+=Sn1kZWH9PsQTouESWQg7CoDpGQR6-gqAFGAFp=Xp_0yhB-Q at mail dot gmail dot com> <54BAE53A dot 2080308 at redhat dot com> <CAOyqgcVi2hUSJXpcEjSNiVLb2ex30CE0HPZSW6BAdLXwM+-1Ag at mail dot gmail dot com> <mvmoapvukuu dot fsf at hawking dot suse dot de>

On 01/19/2015 02:26 AM, Andreas Schwab wrote:
> Ian Lance Taylor <iant@golang.org> writes:
> 
>> @@ -83,7 +83,7 @@
>>  #else /* !defined(USE_LIBFFI_CLOSURES) */
>>  
>>  void
>> -makeFuncFFI(const struct __go_func_type *ftyp, ffi_go_closure *impl)
>> +makeFuncFFI(const struct __go_func_type *ftyp, void *impl)
>>  {
>>    runtime_panicstring ("libgo built without FFI does not support "
>>  		       "reflect.MakeFunc");
> 
> ../../../libgo/go/reflect/makefunc_ffi_c.c: In function âmakeFuncFFIâ:
> ../../../libgo/go/reflect/makefunc_ffi_c.c:86:42: error: unused parameter âftypâ [-Werror=unused-parameter]
>  makeFuncFFI(const struct __go_func_type *ftyp, void *impl)
>                                           ^
> ../../../libgo/go/reflect/makefunc_ffi_c.c:86:54: error: unused parameter âimplâ [-Werror=unused-parameter]
>  makeFuncFFI(const struct __go_func_type *ftyp, void *impl)

Fixed thus; applying to mainline after build testing a cross tomips64el-linux.

Ian, I assume you'll push this upstream?


r~

Attachment: z
Description: Text document

Follow-Ups:
- Re: Use static chain and libffi for Go closures
  - From: Ian Lance Taylor

References:
- Use static chain and libffi for Go closures
  - From: Richard Henderson
- Re: Use static chain and libffi for Go closures
  - From: Andreas Schwab
- Re: Use static chain and libffi for Go closures
  - From: Richard Henderson
- Re: Use static chain and libffi for Go closures
  - From: Andreas Schwab
- Re: Use static chain and libffi for Go closures
  - From: Richard Henderson
- Re: Use static chain and libffi for Go closures
  - From: Andrew Pinski
- Re: Use static chain and libffi for Go closures
  - From: Andreas Schwab
- Re: Use static chain and libffi for Go closures
  - From: Andrew Pinski
- Re: Use static chain and libffi for Go closures
  - From: Richard Henderson
- Re: Use static chain and libffi for Go closures
  - From: Ian Lance Taylor
- Re: Use static chain and libffi for Go closures
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]