This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Tim Shen <timshen at google dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 18 Jan 2015 01:22:44 +0000
- Subject: Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNmMbv4c-bix8VZV8CrudrZZOgMas3cKPhLwoiTnPOMUCA at mail dot gmail dot com> <20150116121217 dot GA3360 at redhat dot com> <CAG4ZjNndkWfK_zOkO5BK66jEQ+BQS+rGQ9nDGTzrQBZfLeZNJw at mail dot gmail dot com> <CAG4ZjNnkipPA1HaAJADdVHe_C2wFaAksxu5W5KF94oEXgwQPFg at mail dot gmail dot com> <20150118002426 dot GW3360 at redhat dot com> <CAG4ZjNmMVGiSphQyg-jgjLu+uHdAABj0t8Rs+tafETM3-WBrdw at mail dot gmail dot com>
On 17/01/15 16:53 -0800, Tim Shen wrote:
Then "std::move on a pointer definitely doesn't pessimize" is true.
Here I read pessimize as "less efficient".
Well without optimization it certainly is less efficient, because you
get calls to std::move (just compare the code for foo and bar at
http://goo.gl/lTxgBw), but I'm confident even at -O1 they disappear
and its nothing to worry about.
Anyway, I'll review your new patches tomorrow - thanks.
- References:
- [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant
- Re: [Patch, libstdc++/64584, libstdc++/64585] Clear basic_regex after imbue and make assign exception tolerant