Re: Use static chain and libffi for Go closures

[Richard Henderson <rth at redhat dot com>]

On 01/17/2015 02:07 PM, Andrew Pinski wrote:
> On Sat, Jan 17, 2015 at 2:02 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Andrew Pinski <pinskia@gmail.com> writes:
>>
>>> On Sat, Jan 17, 2015 at 1:26 PM, Richard Henderson <rth@redhat.com> wrote:
>>>> On 01/17/2015 11:07 AM, Andreas Schwab wrote:
>>>>> Richard Henderson <rth@redhat.com> writes:
>>>>>
>>>>>> On 01/17/2015 01:52 AM, Andreas Schwab wrote:
>>>>>>> ../../../libgo/go/reflect/makefunc_ffi_c.c:21:53: error: unknown type name 'ffi_go_closure'
>>>>>>>  void makeFuncFFI(const struct __go_func_type *ftyp, ffi_go_closure *impl)
>>>>>>>                                                      ^
>>>>>>> ../../../libgo/go/reflect/makefunc_ffi_c.c:86:48: error: unknown type name 'ffi_go_closure'
>>>>>>>  makeFuncFFI(const struct __go_func_type *ftyp, ffi_go_closure *impl)
>>>>>>>                                                 ^
>>>>>>> make[4]: *** [reflect/makefunc_ffi_c.lo] Error 1
>>>>>>
>>>>>> What target?
>>>>>
>>>>> Why does it matter?
>>>>
>>>> Because I don't see that error here, obviously.
>>>
>>>
>>> It fails for me with mips64-linux-gnu.
>>
>> It fails almost everywhere.
> 
> 
> Well it is working for aarch64-linux-gnu and x86_64-linux-gnu (the two
> other targets I care about).

I tested non-support of libffi go closures before applying the patches
for them for ppc, but I guess I busted something in the meantime.

Please try this.


r~

Attachment: z
Description: Text document