This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH PR64434]
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Yuri Rumyantsev <ysrumyan at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Igor Zamyatin <izamyatin at gmail dot com>
- Date: Wed, 14 Jan 2015 14:55:47 +0100
- Subject: Re: [PATCH PR64434]
- Authentication-results: sourceware.org; auth=none
- References: <CAEoMCqR7iJ3kt+G8r95B44EtQG1VDe2a2+tg2ejTv7jqNeo5Fw at mail dot gmail dot com> <20150114102338 dot GL1405 at tucnak dot redhat dot com> <CAEoMCqTN2v1rTc62CDXjoq-4aoAgBhoLQZTK5a4un7ZF3d22+Q at mail dot gmail dot com> <20150114104523 dot GM1405 at tucnak dot redhat dot com> <CAFiYyc08CADzzK6dRnqiA3WvkTQsPRo26HVyQR8g2OtMs4MV4w at mail dot gmail dot com> <20150114110249 dot GN1405 at tucnak dot redhat dot com> <CAEoMCqQHxCrcE9-vKBc_cJZ-P4Jf4Y8sWpgVA1xOz8UyWWUThg at mail dot gmail dot com> <20150114133336 dot GQ1405 at tucnak dot redhat dot com>
On Wed, Jan 14, 2015 at 2:33 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Jan 14, 2015 at 04:28:42PM +0300, Yuri Rumyantsev wrote:
>> Hi All,
>>
>> I did all changes proposed by Richard and delete check on def in the
>> same block as Jakub proposed.
>> I also moved check on optimization to call site..
>>
>> I also checked that bootstrap and regression testing did not show any
>> new failures.
>>
>> Is it OK for trunk?
>
> The | SSA_OP_VUSE is still in there, the testcase is still executable,
> still doesn't end with newline, and I really think you should replace
> lattice = XALLOCAVEC (unsigned int, n);
> with something like:
> if (n >= 100000)
> lattice = XNEWVEC (unsigned int, n);
> else
> lattice = XALLOCAVEC (unsigned int, n);
> ...
> if (n >= 100000)
> XDELETE (lattice);
> or similar.
Just unconditionally allocate from the heap.
Richard.
>
> Jakub