This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [doc] fix documentation of -fvtable-verify and related options


On 01/08/2015 10:10 PM, Jeff Law wrote:
On 01/08/15 15:08, Sandra Loosemore wrote:
This patch cleans up the documentation of -fvtable-verify, -fvtv-debug,
and -fvtv-counts.  The substantive change is to correct the location of
the debug log files per discussion here:

https://gcc.gnu.org/ml/gcc/2015-01/msg00029.html

but I ended up doing a pretty much total rewrite of the text to fix
various markup problems, issues with agreement of verb tense and
plurals, usage of terms like "runtime", etc.

I think this particular patch goes a little beyond an obvious fix, so I
have not committed it yet.  But, I don't want it to get lost in the
shuffle, so I propose to do so in a few days if I don't hear any
objection or request for more time to review it meanwhile.

-Sandra


2015-01-08  Sandra Loosemore  <sandra@codesourcery.com>

     gcc/
     * doc/invoke.texi ([-fvtable-verify]): Copy-edit and fix markup.
     ([-fvtv-debug], [-fvtv-counts]): Likewise.  Correct location
     of log files.

This is fine.  I did note that in some places you use "run time" and
others "run-time".  Not sure if you want those to be consistent or not.

Ok for the trunk.  If you want to make "run time" vs "run-time"
consistent one way or the other consider it preapproved.

As I noted, the "runtime" vs "run time" vs "run-time" changes are deliberate. See

https://gcc.gnu.org/codingconventions.html#Spelling

I did wonder, though, if "startup" should get the same treatment.... but currently "startup" is used consistently throughout the document as both noun and adjective, so any change to that ought to be handled separately.

-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]