This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817
- From: pinskia at gmail dot com
- To: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- Cc: Robert Suchanek <Robert dot Suchanek at imgtec dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>, "vmakarov at redhat dot com" <vmakarov at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Jan 2015 08:00:15 -0800
- Subject: Re: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C31356562440589AC at hhmail02 dot hh dot imgtec dot org> <CABu31nPzNNhAOG6RE3pEu+REkNRu-kA9poQOGNJxeAqmBrRmZQ at mail dot gmail dot com> <B5E67142681B53468FAF6B7C3135656244116DFB at hhmail02 dot hh dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B0235320F9BC22 at LEMAIL01 dot le dot imgtec dot org>
> On Jan 9, 2015, at 4:20 AM, Matthew Fortune <Matthew.Fortune@imgtec.com> wrote:
>
> Robert Suchanek <Robert.Suchanek@imgtec.com> writes:
>
>> gcc/
>> * simplify-rtx.c (simplify_replace_fn_rtx): Simplify (lo_sum (high x)
>> (const (plus x offset))) to (const (plus x offset)).
>
> The fix appears valid to me. Just some comments on the test case.
>
>> a/gcc/testsuite/gcc.target/mips/20150108.c
>> b/gcc/testsuite/gcc.target/mips/20150108.c
>> new file mode 100644
>> index 0000000..f18dbe7
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.target/mips/20150108.c
>> @@ -0,0 +1,25 @@
>> +/* { dg-do compile } */
>> +/* { dg-options "-mips32r2" } */
>
> Please remove this line as there is nothing ISA dependent in the test case.
And since there is no mips specific part to the testcase (except for nomips16), we should place it in the generic part of the testsuite.
Thanks,
Andrew
>
>> +
>> +long long a[10];
>> +long long b, c, d, k, m, n, o, p, q, r, s, t, u, v, w; int e, f, g, h,
>> +i, j, l, x;
>> +
>
> nit, no return type specified.
>
>> +NOMIPS16 fn1() {
>
> Nit, newline for the brace.
>
>> + for (; x; x++)
>> + if (x & 1)
>> + s = h | g;
>> + else
>> + s = f | e;
>> + l = ~0;
>> + m = 1 | k;
>> + n = i;
>> + o = j;
>> + p = f | e;
>> + q = h | g;
>> + w = d | c | a[1];
>> + t = c;
>> + v = b | c;
>> + u = v;
>> + r = b | a[4];
>> +}
>> --
>> 1.7.9.5
>
> Thanks,
> Matthew