Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

["Lynn A. Boger" <laboger at linux dot vnet dot ibm dot com>]

In libgo/go/reflect/makefunc.go, calls to MakeFunc, makeMethodValue and 
makeValueMethod will panic if called when GOARCH is ppc64 or ppc64le.

I understand your point about what you allow into a release branch and 
since it has known bugs with an existing testcase then I agree it 
shouldn't be accepted the way it is.  I will work on fixing that and 
then figure out what branch is best to include it in.

On 01/07/2015 10:54 AM, Ian Lance Taylor wrote:
> On Wed, Jan 7, 2015 at 8:43 AM, Lynn A. Boger
> <laboger@linux.vnet.ibm.com> wrote:
> > I thought that since this only affects ppc64 and ppc64le, and provides
> > reflection support that doesnt exist in gcc 4.9 for Power (you get a panic
> > if you try to use reflection on ppc64, ppc64le), it would be OK.
> I understand that the code doesn't work today in 4.9, but a release
> branch is for releases and backports of bug fixes, not for any sort of
> new development.
>
> (As far as I knoew reflection works in general for PPC in 4.9, it's
> just reflect.MakeFunc, a rarely used feature, that is broken.)
>
> Ian