This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix up DSE - PR middle-end/64388, target/55023
- From: Jakub Jelinek <jakub at redhat dot com>
- To: John David Anglin <dave dot anglin at bell dot net>
- Cc: Jeff Law <law at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 6 Jan 2015 20:12:18 +0100
- Subject: Re: [PATCH] Fix up DSE - PR middle-end/64388, target/55023
- Authentication-results: sourceware.org; auth=none
- References: <1DEC62AA-F782-423D-B110-FC1E48CC97E8 at gmail dot com> <CAMe9rOq5hPS=e6FZug4SbPvjch=KKzP9woUoETYNY8WfJWgxUg at mail dot gmail dot com> <BAB09BDF-695F-4653-A3A1-4B406E38D48A at gmail dot com> <54AA9D75 dot 7050400 at redhat dot com> <20150105185103 dot GW1667 at tucnak dot redhat dot com> <BLU436-SMTP16492009098D2670451691E97580 at phx dot gbl> <20150105212357 dot GY1667 at tucnak dot redhat dot com> <20150105213117 dot GZ1667 at tucnak dot redhat dot com> <20150106140805 dot GK1667 at tucnak dot redhat dot com> <BLU436-SMTP2255278BF749AEF07F2237B97590 at phx dot gbl>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Jan 06, 2015 at 12:07:17PM -0500, John David Anglin wrote:
> On 1/6/2015 9:08 AM, Jakub Jelinek wrote:
> >@@ -2527,7 +2518,13 @@ scan_insn (bb_info_t bb_info, rtx_insn *
> > const_call ? "const" : "memset", INSN_UID (insn));
> > /* See the head comment of the frame_read field. */
> >- if (reload_completed)
> >+ if (reload_completed
> >+ /* Tail calls are storing their arguments using
> >+ arg poinnter. If it is a frame pointer on the target,
> Typo.
Consider it fixed in my copy.
> >+ even before reload we need to kill frame pointer based
> >+ stores. */
> >+ || (SIBLING_CALL_P (insn)
> >+ && HARD_FRAME_POINTER_IS_ARG_POINTER))
> > insn_info->frame_read = true;
>
> I had tested this hunk before, without the
> "HARD_FRAME_POINTER_IS_ARG_POINTER"
> addition, on 32-bit hppa and it resolved the original test case.
Jakub