This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch docs 0/5] Update some of md.texi
- From: Joseph Myers <joseph at codesourcery dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>, <gerald at pfeifer dot com>
- Date: Tue, 6 Jan 2015 14:56:58 +0000
- Subject: Re: [Patch docs 0/5] Update some of md.texi
- Authentication-results: sourceware.org; auth=none
- References: <1420543302-11008-1-git-send-email-james dot greenhalgh at arm dot com>
On Tue, 6 Jan 2015, James Greenhalgh wrote:
> I was aiming to:
>
> * Remove outdated details of the compiler.
> * Remove long or obscure words that, while accurate, only served to
> obfuscate a simple idea.
> * Refer to similar things in a consistent fashion - in particular
> trying to keep consistent use of "insn" and "pattern".
> * Remove superflous examples, or waffling.
> * Update some K&R C and make it use GNU-style.
>
> I've split the patch to a 5-patch series, roughly covering one section
> in each.
It would be much more reviewable if the patches were split logically -
each addressing only one of the five issues you mention above - rather
than physically. As is, I have no idea of the motivation of each of the
changes made by each patch (and, as applicable, the rationale for
considering the change to be (a) correct, (b) not removing any useful
information (for example, the first patch appears to remove the only
documentation of .md comment syntax, but there is no discussion of this
point anywhere in the write-up of that patch), (c) an improvement), and
"Update text." is thoroughly unhelpful as a ChangeLog entry to explain the
intent of the changes.
--
Joseph S. Myers
joseph@codesourcery.com