This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC PATCH 4/9] Add TARGET_LEGITIMIZE_ADDRESS_DISPLACEMENT target macro
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: vmakarov at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org, oleg dot endo at t-online dot de
- Date: Fri, 19 Dec 2014 10:04:29 +0900 (JST)
- Subject: Re: [RFC PATCH 4/9] Add TARGET_LEGITIMIZE_ADDRESS_DISPLACEMENT target macro
- Authentication-results: sourceware.org; auth=none
- References: <20141218 dot 100046 dot 337578930 dot kkojima at rr dot iij4u dot or dot jp> <5493448E dot 3050903 at redhat dot com>
Vladimir Makarov <vmakarov@redhat.com> wrote:
>> * lra-constraints.c (process_address_1): Try if target can split
>> displacement with targetm.legitimize_address_displacement.
>> * target.def (legitimize_address_displacement): New hook.
>> * targhooks.c (default_legitimize_address_displacement): New function.
>> * targhooks.h (default_legitimize_address_displacement): Declare.
>> * config/sh/sh.c (sh_legitimize_address_displacement): New function.
>> (TARGET_LEGITIMIZE_ADDRESS_DISPLACEMENT): Define.
>> * doc/tm.texi.in (TARGET_LEGITIMIZE_ADDRESS_DISPLACEMENT): New hook.
>> * doc/tm.texi: Regenerate.
>>
>
> It is an interesting solution.
>
> The patch is ok for me.
>
> One more thing though. The patches you propose affect very sensitive
> parts of LRA. They might break other ports currently using LRA. If
> it happens, please, revert a breaking patch as I can not be a help
> next 2 weeks.
I'll revert them ASAP if it causes something on trunk.
Thanks for your review!
Regards,
kaz