This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR 61225
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Zhenqiang Chen <zhenqiang dot chen at arm dot com>
- Cc: "'Jeff Law'" <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 12 Dec 2014 05:08:39 -0600
- Subject: Re: [PATCH] Fix PR 61225
- Authentication-results: sourceware.org; auth=none
- References: <CACgzC7D40=bxqag59GYQuXtze_ZAquo3PhpLmh0EGxZte5Mw4A at mail dot gmail dot com> <53C73EBD dot 9070909 at redhat dot com> <CACgzC7CJnoaOsFMDjXDZ0CLiECWPbejxDHg2GOk_AUtjrzC80w at mail dot gmail dot com> <547CE75B dot 6090709 at redhat dot com> <000001d00f9e$64f43600$2edca200$ at arm dot com> <54861817 dot 4030409 at redhat dot com> <000301d01395$675d5890$361809b0$ at arm dot com> <20141209190744 dot GA8314 at gate dot crashing dot org> <54874A52 dot 3030304 at redhat dot com> <000101d015dd$1042e6c0$30c8b440$ at arm dot com>
On Fri, Dec 12, 2014 at 03:27:17PM +0800, Zhenqiang Chen wrote:
> > Presumably you're thinking about a PARALLEL that satisfies single_set_p?
>
> No. It has nothing to do with single_set_p. I just want to reuse the code to
> match the instruction pattern.
>
> In common, the new PARALLEL is like
>
> Parallel
> newpat from I3
> newpat from I2 // if have
> newpat from I1 // if have
> newpat from I0 // if have
>
> For to_combined_insn, i0 is NULL and there should have no
>
> newpat from I1
>
> When handling I1->I2->I3, with normal order, it will get
> Parallel
> newpat from I3
>
> After I2-> to_combined_insn, the parallel will be
> Parallel
> newpat from I3
> newpat from to_combined_insn.
>
> But this can not match the insn pattern. So I swap the order to.
> Parallel
> newpat from to_combined_insn.
> newpat from I3
Maybe I wasn't clear, sorry. My concern is you only handle a SET as
newpat, not a PARALLEL. It can be a PARALLEL just fine, even if it
satisfies single_set (it can have a clobber, it can have multiple sets,
all but one dead).
Thanks for the other changes, much appreciated.
Segher