This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Martin LiÅka <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "hubi >> Jan Hubicka" <hubicka at ucw dot cz>
- Date: Thu, 11 Dec 2014 13:37:13 +0100
- Subject: Re: [PATCH] IPA ICF: refactoring + fix for PR ipa/63569
- Authentication-results: sourceware.org; auth=none
- References: <54883A2C dot 4050301 at suse dot cz>
On Wed, Dec 10, 2014 at 1:18 PM, Martin LiÅka <mliska@suse.cz> wrote:
> Hello.
>
> As suggested by Richard, I split compare_operand functions to various
> functions
> related to a specific comparison. Apart from that I added fast check for
> volatility flag that caused miscompilation mentioned in PR63569.
>
> Patch can bootstrap on x86_64-linux-pc without any regression seen and I was
> able to build Firefox with LTO.
>
> Ready for trunk?
Hmm, I don't think the dispatch to compare_memory_operand is at the
correct place. It should be called from places where currently
compare_operand is called and it should recurse to compare_operand.
That is, it is more "high-level".
Can you please fix the volatile issue separately? It's also not necessary
to do that check on every operand but just on memory operands.
Thanks,
Richard.
> Thanks,
> Martin