Re: [PATCH, CHKP] Fix instrumentation clones privatization

[James Greenhalgh <james dot greenhalgh at arm dot com>]

On Wed, Dec 10, 2014 at 06:19:08PM +0000, Ilya Enkovich wrote:
> 2014-12-10 21:07 GMT+03:00 James Greenhalgh <james.greenhalgh@arm.com>:
> > In the interests of breaking us out of this loop...
> >
> > At least: {arm-none-linux-gnueabihf, arm-none-eabi,
> >             aarch64-none-linux-gnueabi, aarch64-none-elf, aarch64_be-none-elf}
> > fail for me.
> 
> Hello James,
> 
> Could you please attach a gcc.log file for one of your runs?

Sure, see below.

However, the problem is your dg-require-effective-target line for the test.

>From the documentation:

{ dg-require-effective-target keyword [{ selector }] }
    Skip the test if the test target, including current multilib flags, is not
    covered by the effective-target keyword. If the directive includes the
    optional â{ selector }â then the effective-target test is only performed if
    the target system matches the selector. 

So what you've written is really the opposite of what you meant :)

i.e.

/* { dg-require-effective-target mpx { target { i?86-*-* x86_64-*-* } } } */

Should look more like:

/* { dg-require-effective-target mpx } */

Which gets me the UNSUPPORTED I expect to see for this test.

Cheers,
James

---
Executing on host: /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/  -fno-diagnostics-show-caret -fdiagnostics-color=never   -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx   -c -specs=aem-ve.specs    -mcmodel=small  -o c_lto_chkp-privatize_0.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c    (timeout = 300)
spawn /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_0.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_0.c
xgcc: error: unrecognized command line option '-mmpx'
compiler exited with status 1
output is:
xgcc: error: unrecognized command line option '-mmpx'

FAIL: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o assemble,  -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx 
Executing on host: /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/  -fno-diagnostics-show-caret -fdiagnostics-color=never   -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx   -c -specs=aem-ve.specs    -mcmodel=small  -o c_lto_chkp-privatize_1.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_1.c    (timeout = 300)
spawn /work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/xgcc -B/work/gcc-clean/build-aarch64-none-elf/obj/gcc2/gcc/ -fno-diagnostics-show-caret -fdiagnostics-color=never -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx -c -specs=aem-ve.specs -mcmodel=small -o c_lto_chkp-privatize_1.o /work/gcc-clean/src/gcc/gcc/testsuite/gcc.dg/lto/chkp-privatize_1.c
xgcc: error: unrecognized command line option '-mmpx'
compiler exited with status 1
output is:
xgcc: error: unrecognized command line option '-mmpx'

FAIL: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_1.o assemble,  -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx 
UNRESOLVED: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o-c_lto_chkp-privatize_1.o link  -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx 
UNRESOLVED: gcc.dg/lto/chkp-privatize c_lto_chkp-privatize_0.o-c_lto_chkp-privatize_1.o execute  -fPIC -flto -flto-partition=max -fcheck-pointer-bounds -mmpx