This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH][MIPS] Fix P5600 memory cost
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Prachi Godbole <Prachi dot Godbole at imgtec dot com>, "Jeff Law <law at redhat dot com> (law at redhat dot com)" <law at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 9 Dec 2014 22:33:59 +0000
- Subject: RE: [PATCH][MIPS] Fix P5600 memory cost
- Authentication-results: sourceware.org; auth=none
- References: <72E73D4BBFC6704695754C43662FC58458835EFB at PUMAIL01 dot pu dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B0235320F6AAB1 at LEMAIL01 dot le dot imgtec dot org> <72E73D4BBFC6704695754C43662FC5845883984C at PUMAIL01 dot pu dot imgtec dot org>
Hi Prachi,
I'm afraid you updated the wrong Changelog with this commit. GCC changes
are recorded in gcc/ChangeLog.
I'm not sure what the correct procedure is for fixing this.
Jeff: Should a mistake like this be fixed by removing the entry
from the top level and adding one at the appropriate location in the
gcc/ChangeLog one?
Thanks,
Matthew
> -----Original Message-----
> From: Prachi Godbole
> Sent: 26 November 2014 08:40
> To: Matthew Fortune; gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH][MIPS] Fix P5600 memory cost
>
> Committed with ChangeLog entry fixes.
>
> Prachi
>
>
> -----Original Message-----
> From: Matthew Fortune
> Sent: Wednesday, November 5, 2014 4:07 PM
> To: Prachi Godbole; gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH][MIPS] Fix P5600 memory cost
>
> > The patch below fixes the memory cost for P5600.
> >
> > ChangeLog:
> > 2014-11-05 Prachi Godbole <prachi.godbole@imgtec.com>
> >
> > * config/mips/mips.c (mips_rtx_cost_data): Fix memory_letency cost for
> > p5600.
>
> Please follow these instructions to add yourself to MAINTAINERS in the
> write-after-approval section now that you have write access to GCC:
>
> https://gcc.gnu.org/svnwrite.html#authenticated
>
> OK with fixes to the changelog entry:
>
> latency not latency. Remember to tab in the changelog entry and split
> the line as it will exceed 80 chars. Also two spaces between the
> date/name and name/email. E.g.
>
> 2014-11-05 Prachi Godbole <prachi.godbole@imgtec.com>
>
> * config/mips/mips.c (mips_rtx_cost_data): Fix memory_latency cost
> for
> p5600.
>
> Thanks,
> Matthew
>
> > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c index
> > af6a913..558ba2f 100644
> > --- a/gcc/config/mips/mips.c
> > +++ b/gcc/config/mips/mips.c
> > @@ -1193,7 +1193,7 @@ static const struct mips_rtx_cost_data
> > COSTS_N_INSNS (8), /* int_div_si */
> > COSTS_N_INSNS (8), /* int_div_di */
> > 2, /* branch_cost */
> > - 10 /* memory_latency */
> > + 4 /* memory_latency */
> > }
> > };
> > ^L