This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Android] Stop unconditional disabling of ifuncs for Bionic #2

From: Jeff Law <law at redhat dot com>
To: Alexander Ivchenko <aivchenk at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Cc: enh <enh at google dot com>, Andrew Hsieh <andrewhsieh at google dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
Date: Tue, 09 Dec 2014 11:43:05 -0700
Subject: Re: [Android] Stop unconditional disabling of ifuncs for Bionic #2
Authentication-results: sourceware.org; auth=none
References: <CACysShi0Xm_HKFJXp8dTR5Twok=twE9JY7eh2jxe+ri0GAEGSw at mail dot gmail dot com>

On 12/09/14 05:39, Alexander Ivchenko wrote:

Hi,

Whether the *linux* target supports ifuncs or not is defined here:

linux_has_ifunc_p (void)
{
   return OPTION_BIONIC ? false : HAVE_GNU_INDIRECT_FUNCTION;
}

Bionic right now supports indirect functions, but there is no way to
notify the compiler about that (For Android OPTION_BIONIC is always on
and so configure time check with --enable-gnu-indirect-function does
not work)

The following patch makes the use of the default version of
TARGET_HAS_IFUNC_P for *linux*, so we can decide whether the Android
target supports indirect functions or not on configure time.

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f22bba8..d4d09d0 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-08  Alexander Ivchenko  <alexander.ivchenko@intel.com>
+
+       * config/linux.c (linux_has_ifunc_p): Remove.
+       * config/linux.h (TARGET_HAS_IFUNC_P): Use default version.

OK.
jeff

References:
- [Android] Stop unconditional disabling of ifuncs for Bionic #2
  - From: Alexander Ivchenko

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]