This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] PR 61692 - Fix for inline asm ICE

From: Jeff Law <law at redhat dot com>
To: David Wohlferd <dw at LimeGreenSocks dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 08 Dec 2014 14:59:44 -0700
Subject: Re: [Patch] PR 61692 - Fix for inline asm ICE
Authentication-results: sourceware.org; auth=none
References: <53D4A9A2 dot 2050402 at LimeGreenSocks dot com> <53D6A79E dot 8060300 at redhat dot com> <53D6D107 dot 3030404 at LimeGreenSocks dot com> <53D9CCE4 dot 8010305 at redhat dot com> <53DB4AB5 dot 4010709 at LimeGreenSocks dot com> <53DBDC86 dot 7060809 at redhat dot com> <54154E0D dot 30806 at LimeGreenSocks dot com> <54175F6A dot 70609 at redhat dot com> <54682138 dot 70008 at LimeGreenSocks dot com>

On 11/15/14 20:59, David Wohlferd wrote:

On 9/15/2014 2:51 PM, Jeff Law wrote:

Let's go with your original inputs + outputs + labels change and punt
the clobbers stuff for now.

jeff


I have also added the test code you requested.

I have a release on file with the FSF, but don't have SVN write access.

Problem:
extract_insn() in recog.c will ICE if (noperands > MAX_RECOG_OPERANDS).
Normally this isn't a problem since expand_asm_operands() in cfgexpand.c
catches and reports a proper error for this condition.  However,
expand_asm_operands() only checks (ninputs + noutputs) instead of
(ninputs + noutputs + nlabels), so you can get the ICE when using "asm
goto."

ChangeLog:
2014-11-15  David Wohlferd <dw@LimeGreenSocks.com>

         PR target/61692
         * cfgexpand.c (expand_asm_operands): Count all inline asm params.
         * testsuite/gcc.dg/pr61692.c: New test.

Thanks. I put the testsuite ChangeLog entry in the right place andadded a dg-do directive to the testcase to ensure we just try to compile it.

Thanks for your patience, things got rather busy and obviously I'm stillworking through my personal backlog of patches from folks.


Jeff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]