This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name

From: Jeff Law <law at redhat dot com>
To: Ilya Enkovich <enkovich dot gnu at gmail dot com>
Cc: Richard Biener <richard dot guenther at gmail dot com>, Jan Hubicka <hubicka at ucw dot cz>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 08 Dec 2014 14:33:45 -0700
Subject: Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name
Authentication-results: sourceware.org; auth=none
References: <20141125084543 dot GD9490 at msticlxl57 dot ims dot intel dot com> <CAFiYyc14BPU3pwQT_02vvTsOFTHbdZji+AnHhnvWf3+-dEooyg at mail dot gmail dot com> <CAMbmDYZ2=5zXr9KFbQ0GdG=4XF2n6uVrmq_3p=FCGNzNiQSuLw at mail dot gmail dot com> <CAFiYyc1LMgBcPWqJo3KsXbkURGoMrne_KPaFc-hJHC_o7dpoVg at mail dot gmail dot com> <CAMbmDYZi56LQe68XFR17P7zEqna0Ocb65DT0fALy08Hi+TV+7g at mail dot gmail dot com> <20141126123545 dot GB40854 at msticlxl57 dot ims dot intel dot com> <CAMbmDYZ2_aZuK-Kn8F_XrvOViUwOBPPft+usL-K-v+X8BY98qw at mail dot gmail dot com> <5486117F dot 3050908 at redhat dot com> <CAMbmDYbP4TRiPJeG1gg=Sk+UNESx8zyLZC0j05ZeSKt+TYsDzw at mail dot gmail dot com>

On 12/08/14 14:12, Ilya Enkovich wrote:

2014-12-09 0:00 GMT+03:00 Jeff Law <law@redhat.com>:

On 12/08/14 04:00, Ilya Enkovich wrote:


2014-11-26  Ilya Enkovich  <ilya.enkovich@intel.com>

          PR bootstrap/63995
          * tree-chkp.c (chkp_make_static_bounds): Share bounds var
          between nodes sharing assembler name.

gcc/testsuite

2014-11-26  Ilya Enkovich  <ilya.enkovich@intel.com>

          PR bootstrap/63995
          * g++.dg/dg.exp: Add mpx-dg.exp.
          * g++.dg/pr63995-1.C: New.


Code seems fine.  Not sure how the testcase is actually testing that you're
sharing bounds though.  The test AFAICT just verifies that it can be
compiled and doesn't checkout the output in any way.  Or is it the case that
the test will ICE or segfault without your fix?


Without this fix compiler emits two symbols with the same name and
assembler complains. Something like that:

/tmp/cceHGHa1.s: Assembler messages:
/tmp/cceHGHa1.s:12080: Error: symbol `__chkp_bounds_of_mode_inner' is
already defined
/tmp/cceHGHa1.s:12086: Error: symbol `__chkp_bounds_of_mode_nunits' is
already defined

Ah OK.  Ok for the trunk.

Thanks for your patience,
Jeff

References:
- Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name
  - From: Ilya Enkovich
- Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name
  - From: Jeff Law
- Re: [PATCH, PR63995, CHKP] Use single static bounds var for varpool nodes sharing asm name
  - From: Ilya Enkovich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]