This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, i386] Fix PR64003

From: Jeff Law <law at redhat dot com>
To: Ilya Enkovich <enkovich dot gnu at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Fri, 05 Dec 2014 13:25:37 -0700
Subject: Re: [PATCH, i386] Fix PR64003
Authentication-results: sourceware.org; auth=none
References: <20141205145738 dot GB53395 at msticlxl57 dot ims dot intel dot com>

On 12/05/14 07:57, Ilya Enkovich wrote:

Hi,

This patch fixes PR target/64003 by avoiding functions calls during computations of "length" attribute for short jump instructions.  It is achieved by having separate templates for prefixed and not prefixed instructions.  Please see discussion in bugzilla for reasoning.

Bootstrapped and tested on x86_64-unknown-linux-gnu.  Valgrind run for reproducer shows problem is fixed.  OK for trunk?

Thanks,
Ilya
--
2014-12-05  Ilya Enkovich  <ilya.enkovich@intel.com>

	* config/i386/i386.md (*jcc_1_bnd): New.
	(*jcc_2_bnd): New.
	(jump_bnd): New.
	(*jcc_1): Remove bnd prefix.
	(*jcc_2): Likewise.
	(jump): Likewise.

Just wanted to say thanks for taking care of this. The obscure andundocumented rules about what can appear in these length computationsis, umm, bad and I don't think anyone could reasonably have expected youto know about them.


jeff

References:
- [PATCH, i386] Fix PR64003
  - From: Ilya Enkovich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]